Skip to content

Installer: remove files older builds shipped that the app no longer needs - #212

Merged
demortes merged 1 commit into
mainfrom
fix/installer-cleanup
Oct 11, 2026
Merged

demortes merged 1 commit into
mainfrom
fix/installer-cleanup

Conversation

@demortes

Copy link
Copy Markdown
Contributor

Follow-up to #211, which merged before this commit was pushed.

An in-place upgrade only overwrites files the new build still ships, so existing installs would keep the x86/arm64 VLC builds, libvlc.dylib and the native .pdb files (~320 MB) and stay near 541 MB. [InstallDelete] clears them before the new files are copied.

Paths verified against an existing 541 MB install. Not compiled locally (no Inno Setup here); CI/release build is the first real compile.

🤖 Generated with Claude Code

…eeds

An in-place upgrade only overwrites files the new build still ships, so
existing installs would keep the x86/arm64 VLC builds, libvlc.dylib and
the native .pdb files (~320 MB) even after this change. Clear them with
[InstallDelete] before the new files are copied.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e21a9e59-c2cc-4ad2-9680-4e13d5919ea1

📥 Commits

Reviewing files that changed from the base of the PR and between 923df51 and 16cb412.


📒 Files selected for processing (1)
  • installer/windows/ednexus.iss

 ______________________________________________________
< Review complete: I laughed, I cried, I filed issues. >
 ------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@demortes
demortes merged commit 2adad61 into main Oct 11, 2026
1 of 2 checks passed
@demortes
demortes deleted the fix/installer-cleanup branch October 11, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant