Repository navigation
Installer: remove files older builds shipped that the app no longer needs - #212
Merged
Merged
Conversation
…eeds An in-place upgrade only overwrites files the new build still ships, so existing installs would keep the x86/arm64 VLC builds, libvlc.dylib and the native .pdb files (~320 MB) even after this change. Clear them with [InstallDelete] before the new files are copied. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #211, which merged before this commit was pushed.
An in-place upgrade only overwrites files the new build still ships, so existing installs would keep the x86/arm64 VLC builds,
libvlc.dyliband the native.pdbfiles (~320 MB) and stay near 541 MB.[InstallDelete]clears them before the new files are copied.Paths verified against an existing 541 MB install. Not compiled locally (no Inno Setup here); CI/release build is the first real compile.
🤖 Generated with Claude Code