Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 2 vulnerabilities #7117

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Feb 15, 2025

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • frontend/package.json
  • frontend/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-6147607
  626  
low severity Cross-site Scripting (XSS)
SNYK-JS-DOMPURIFY-8722251
  493  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)


Important

Upgrade dompurify and webpack in frontend/package.json to fix XSS vulnerabilities.

  • Dependencies:
    • Upgrade dompurify from 3.1.3 to 3.2.4 in frontend/package.json to fix XSS vulnerability.
    • Upgrade webpack from 5.94.0 to 5.98.0 in frontend/package.json to fix XSS vulnerability.
  • Files:
    • Update frontend/package.json and frontend/yarn.lock for dependency changes.
  • Notes:
    • Zero-installs users must run yarn to update .yarn/cache/ directory.

This description was created by Ellipsis for da3eb2b. It will automatically update as commits are pushed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the bug Something isn't working label Feb 15, 2025
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to da3eb2b in 39 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. frontend/package.json:71
  • Draft comment:
    Updated dompurify version. Ensure that no breaking changes (API or security behavior) were introduced in 3.2.4. Verify that related usage across the app is compatible.
  • Reason this comment was not posted:
    Marked as duplicate.
2. frontend/package.json:130
  • Draft comment:
    Upgraded webpack to 5.98.0. Confirm that this upgrade does not introduce incompatibilities in the build setup.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/package.json:70
  • Draft comment:
    Bump 'dompurify' from 3.1.3 to 3.2.4 to address XSS vulnerabilities (SNYK-JS-DOMPURIFY-8722251). Please verify that this update doesn't break any usages in the project.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is related to a dependency change, specifically a version bump for 'dompurify'. The comment asks the PR author to verify that the update doesn't break any usages, which violates the rule against asking for confirmation or verification. Therefore, this comment should not be approved.
4. frontend/package.json:129
  • Draft comment:
    Upgrade 'webpack' from 5.94.0 to 5.98.0 to patch potential vulnerabilities. Ensure that the custom webpack configuration remains compatible with this version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is related to a dependency change, specifically upgrading 'webpack'. The comment suggests ensuring compatibility with custom configurations, which falls under asking the PR author to ensure behavior is intended or tested. This violates the rules.

Workflow ID: wflow_d8xyTzzsJC2Ksqpi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants