Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alertmanager): add alertmanagertypes #7101

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

grandwizard28
Copy link
Collaborator

@grandwizard28 grandwizard28 commented Feb 12, 2025

Summary

add alertmanagertypes


Important

Add alert manager types and enhance error handling with structured codes, updating related tests and HTTP rendering.

  • Alert Manager Types:
    • Add alertmanagertypes package with alert.go, channel.go, config.go, marker.go, receiver.go, and state.go.
    • Implement functions for creating, updating, and deleting alert manager configurations and channels.
    • Add tests for alert manager configurations and channels in channel_test.go.
  • Error Handling:
    • Introduce code type in pkg/errors/code.go for structured error codes.
    • Modify errors.go to use code type for error codes.
    • Update tests in errors_test.go to reflect changes in error handling.
  • HTTP Rendering:
    • Update render.go to use code type for error codes in HTTP responses.
    • Adjust tests in render_test.go to match new error handling.
  • Miscellaneous:
    • Remove NotificationChannel from dashboard.go as it's now handled in alertmanagertypes.

This description was created by Ellipsis for ba5746e. It will automatically update as commits are pushed.

@grandwizard28 grandwizard28 enabled auto-merge (squash) February 12, 2025 17:23
@grandwizard28 grandwizard28 merged commit bcf7bf3 into main Feb 12, 2025
16 of 17 checks passed
@grandwizard28 grandwizard28 deleted the types/alertmanager branch February 12, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants