-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: raw log data not rendering in log context #6991
fix: raw log data not rendering in log context #6991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 5cbdd3a in 1 minute and 44 seconds
More details
- Looked at
62
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/pages/TraceDetailV2/TraceDetailV2.tsx:71
- Draft comment:
Consider adding null checks fortraceData?.payload
in other usages to ensure consistency and avoid potential null reference errors. - Reason this comment was not posted:
Comment was on unchanged code.
2. frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.tsx:110
- Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This is also applicable to other inline styles in the file. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_Kw9IgRBP3O6CKKOC
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
5cbdd3a
to
b389d37
Compare
b389d37
to
44cd538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 44cd538 in 22 seconds
More details
- Looked at
57
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/container/LogDetailedView/ContextView/ContextLogRenderer.tsx:22
- Draft comment:
EnsuredefaultLogsSelectedFields
is not used elsewhere in the codebase, as its redefinition here might break other parts of the application. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ehOCQd52ZFwT7wAz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Related Issues / PR's
Thread: https://signoz-team.slack.com/archives/C089D1B5516/p1738256980047269
Screenshots
Before:

After:

Affected Areas and Manually Tested Areas
Important
Fix raw log data rendering in
ContextLogRenderer.tsx
and add null check for trace data inTraceDetailV2.tsx
.defaultLogsSelectedFields
inContextLogRenderer.tsx
to ensure raw log data is rendered with default selected fields.selectedFields
toRawLogView
inContextLogRenderer.tsx
.traceData?.payload?.spans?.length
inTraceDetailV2.tsx
to prevent errors when spans are undefined.useEffect
dependencies inContextLogRenderer.tsx
andTraceDetailV2.tsx
.This description was created by
for 44cd538. It will automatically update as commits are pushed.