fix: handle exists and nexists for mat columns and top level columns #6672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6584
Now the logic for exists/nexists is similar to that of logs. For top level columns it will try to check if it's empty string or number is not equal to zero.
For materialized columns it will use the
exists
column for that materialized column.This needs to be released before releasing this
Important
Refactor
exists
/not exists
handling for top-level and materialized columns inquery_builder.go
, updating tests accordingly.exists
andnot exists
operators inquery_builder.go
to handle both top-level and materialized columns.exists
column.getExistsNexistsFilter()
inquery_builder.go
to centralizeexists
/not exists
logic.existsSubQueryForFixedColumn()
as its logic is now ingetExistsNexistsFilter()
.Test_buildTracesFilterQuery
andTest_buildTracesQuery
inquery_builder_test.go
to reflect newexists
/not exists
logic.This description was created by for 161f5fd. It will automatically update as commits are pushed.