chore: develop deprecation and related changes #6668
Conversation
feat: support trace v3 queries
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 502f311 in 41 seconds
More details
- Looked at
237lines of code in14files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. CONTRIBUTING.md:339
- Draft comment:
Update the contribution guidelines to reflect that contributions should be made to the 'main' branch instead of the 'develop' branch. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_VQvSWGomEkiMSyzu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
* nit: update resource id and revert the flag
Co-authored-by: Nityananda Gohain <nityanandagohain@gmail.com>
* feat: api for trace materialization * fix: minor changes and cleanup * fix: minor fixes * fix: update errors * fix: address comments * fix: address comments
prashant-shahi
force-pushed
the
chore/deprecate-develop
branch
from
c42461b to
42fefc6
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 42fefc6 in 1 minute and 23 seconds
More details
- Looked at
237lines of code in14files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. deploy/README.md:61
- Draft comment:
The reference to thedevelopbranch should be updated tomainto reflect the deprecation of thedevelopbranch. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. deploy/README.md:61
- Draft comment:
Update the branch reference fromdeveloptomainto reflect the changes made in the PR. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_c9jLrO5DC8Z2QW0q
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…1.15 Signed-off-by: Prashant Shahi <prashant@signoz.io>
…1.16 Signed-off-by: Prashant Shahi <prashant@signoz.io>
Signed-off-by: Prashant Shahi <prashant@signoz.io>
Signed-off-by: Prashant Shahi <prashant@signoz.io>
Summary
Important
Deprecate
developbranch in favor ofmainacross workflows, scripts, and documentation, with updates to Docker images and code refactoring for field handling.developbranch frombuild.yaml,push.yaml,sonar.yml, andjest-coverage-changes.yml.docs.yml,e2e-k3s.yaml,staging-deployment.yaml, andtesting-deployment.yamlto trigger onmain.hotrod-install.shandhotrod-delete.shto usemainbranch.developbranch check infrontend/.husky/commit-msg.CONTRIBUTING.mdanddeploy/README.mdto referencemainbranch.docker-compose.yamlanddocker-compose-core.yamlto new versions.go.modto usesignoz-otel-collector v0.111.16.removeUnderscoreDuplicateFields()inreader.goto usemodel.Fieldinstead ofmodel.LogField.GetTraceFields()andUpdateTraceField()inreader.go.http_handler.gofor trace fields.buildTracesFilterQuery()inquery_builder.goto handle new filter operations.replaceFieldInToken()inparser.goto usemodel.Field.parser_test.goandquery_builder_test.goto reflect changes in field handling.This description was created by
for 42fefc6. It will automatically update as commits are pushed.