-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Request Dashboard button and improve dashboard list styles #6251
feat: add Request Dashboard button and improve dashboard list styles #6251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 9ecd564 in 56 seconds
More details
- Looked at
196
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. frontend/src/container/ListOfDashboard/RequestDashboardBtn.tsx:25
- Draft comment:
Ensure to handle the response fromlogEvent
properly to check for errors or success. This will help in debugging if the logging fails. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/container/ListOfDashboard/RequestDashboardBtn.tsx:35
- Draft comment:
SetsetIsSubmittingRequestForDashboard(false)
once after the try-catch block to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
ThehandleRequestDashboardSubmit
function setsisSubmittingRequestForDashboard
tofalse
in both success and error cases. This is redundant and can be optimized by setting it once after the try-catch block.
3. frontend/src/container/ListOfDashboard/DashboardsList.tsx:827
- Draft comment:
TheisFilteringDashboards
state is set totrue
and then immediately tofalse
. This state change is unnecessary and can be removed to simplify the code. - Reason this comment was not posted:
Confidence changes required:50%
ThehandleSearch
function inDashboardsList.tsx
setsisFilteringDashboards
totrue
and then immediately tofalse
. This state change is unnecessary and can be removed to simplify the code.
4. frontend/src/container/ListOfDashboard/DashboardsList.tsx:82
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach. It makes it difficult to debug and find components using global search tools. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_nRnyi89imPTX2NCT
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@makeavish , I’m currently using the staging environment for localhost. Could you please guide me on how to enable the empty state in the local setup? |
Can you use a test cloud tenant with zero dashboards? |
we can do it programatically as well, since all the logic is there on frontend we do not need to depend on API to trigger the same.. |
0d1b9c3
to
e5c1195
Compare
Summary
We want to provide users with an easy way to request new dashboards, similar to how they can currently request new integrations. This feature will streamline the process for users and help us gather feedback on what types of dashboards they are looking for.
Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/1925
Screenshots
Important
Add
RequestDashboardBtn
for requesting dashboards and update dashboard list styles.RequestDashboardBtn
component inRequestDashboardBtn.tsx
to allow users to request new dashboards.RequestDashboardBtn
intoDashboardsList.tsx
for cloud users.DashboardList.styles.scss
to adjust spacing and layout for dashboard list.Integrations.styles.scss
to ensure consistent appearance.font-family: Inter
fromIntegrations.styles.scss
.This description was created by for 9ecd564. It will automatically update as commits are pushed.