Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Request Dashboard button and improve dashboard list styles #6251

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

sharpshooter90
Copy link
Contributor

@sharpshooter90 sharpshooter90 commented Oct 24, 2024

Summary

We want to provide users with an easy way to request new dashboards, similar to how they can currently request new integrations. This feature will streamline the process for users and help us gather feedback on what types of dashboards they are looking for.

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/1925

Screenshots

Screenshot 2024-10-24 at 10 42 05 AM Screenshot 2024-10-24 at 10 41 46 AM

Important

Add RequestDashboardBtn for requesting dashboards and update dashboard list styles.

  • Feature:
    • Add RequestDashboardBtn component in RequestDashboardBtn.tsx to allow users to request new dashboards.
    • Integrates RequestDashboardBtn into DashboardsList.tsx for cloud users.
  • Styles:
    • Update DashboardList.styles.scss to adjust spacing and layout for dashboard list.
    • Override styles in Integrations.styles.scss to ensure consistent appearance.
  • Misc:
    • Remove redundant font-family: Inter from Integrations.styles.scss.

This description was created by Ellipsis for 9ecd564. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 9ecd564 in 56 seconds

More details
  • Looked at 196 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. frontend/src/container/ListOfDashboard/RequestDashboardBtn.tsx:25
  • Draft comment:
    Ensure to handle the response from logEvent properly to check for errors or success. This will help in debugging if the logging fails.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. frontend/src/container/ListOfDashboard/RequestDashboardBtn.tsx:35
  • Draft comment:
    Set setIsSubmittingRequestForDashboard(false) once after the try-catch block to avoid redundancy.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The handleRequestDashboardSubmit function sets isSubmittingRequestForDashboard to false in both success and error cases. This is redundant and can be optimized by setting it once after the try-catch block.
3. frontend/src/container/ListOfDashboard/DashboardsList.tsx:827
  • Draft comment:
    The isFilteringDashboards state is set to true and then immediately to false. This state change is unnecessary and can be removed to simplify the code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The handleSearch function in DashboardsList.tsx sets isFilteringDashboards to true and then immediately to false. This state change is unnecessary and can be removed to simplify the code.
4. frontend/src/container/ListOfDashboard/DashboardsList.tsx:82
  • Draft comment:
    Avoid using the component/index.tsx file structure approach. It makes it difficult to debug and find components using global search tools.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_nRnyi89imPTX2NCT


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@makeavish
Copy link
Member

Are we not considering empty dashboard state for requesting dashboard?

Screenshot 2024-10-24 at 08 28 09

@sharpshooter90
Copy link
Contributor Author

Are we not considering empty dashboard state for requesting dashboard?

Screenshot 2024-10-24 at 08 28 09

@makeavish , I’m currently using the staging environment for localhost. Could you please guide me on how to enable the empty state in the local setup?

@makeavish
Copy link
Member

Are we not considering empty dashboard state for requesting dashboard?

Screenshot 2024-10-24 at 08 28 09

@makeavish , I’m currently using the staging environment for localhost. Could you please guide me on how to enable the empty state in the local setup?

Can you use a test cloud tenant with zero dashboards?

@vikrantgupta25
Copy link
Member

I’m currently using the staging environment for localhost. Could you please guide me on how to enable the empty state in the local setup?

we can do it programatically as well, since all the logic is there on frontend we do not need to depend on API to trigger the same..

@YounixM YounixM force-pushed the feat/request-new-dashboard branch from 0d1b9c3 to e5c1195 Compare October 25, 2024 12:55
@makeavish makeavish enabled auto-merge (squash) October 25, 2024 13:03
@makeavish makeavish merged commit 4be0508 into SigNoz:develop Oct 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants