Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource_deployment_environment as fast filter in traces page #5864

Merged

Conversation

ahmadshaheer
Copy link
Collaborator

Summary

Add Environment as a fast filter in trace explorer page.

Related Issues / PR's

part of #3184

Screenshots

image

NA

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Sep 5, 2024
rahulkeswani101
rahulkeswani101 previously approved these changes Sep 5, 2024
vikrantgupta25
vikrantgupta25 previously approved these changes Sep 5, 2024
rahulkeswani101
rahulkeswani101 previously approved these changes Sep 6, 2024
@ankitnayan
Copy link
Collaborator

keep the Environment section expanded by default like Service Name or Status? I see it collapsed by default

@ankitnayan ankitnayan self-requested a review September 8, 2024 10:30
ankitnayan
ankitnayan previously approved these changes Sep 8, 2024
@ahmadshaheer
Copy link
Collaborator Author

keep the Environment section expanded by default like Service Name or Status? I see it collapsed by default

Done, @ankitnayan .

@ankitnayan
Copy link
Collaborator

@SagarRajput-7 I see the QB to fast filters mapping works only for IN operator and not for = operator. Is this expected?

@SagarRajput-7
Copy link
Contributor

@SagarRajput-7 I see the QB to fast filters mapping works only for IN operator and not for = operator. Is this expected?

Yes at that time, this was difficult to cover. So we decided to take it later. Also, @vikrantgupta25 and I discussed covering this with the new Logs filters, as he made it in a generic sense and over our calls, we considered the Traces filter's requirement in mind.

FYI - @vikrantgupta25

@ankitnayan
Copy link
Collaborator

@SagarRajput-7 I see the QB to fast filters mapping works only for IN operator and not for = operator. Is this expected?

Yes at that time, this was difficult to cover. So we decided to take it later. Also, @vikrantgupta25 and I discussed covering this with the new Logs filters, as he made it in a generic sense and over our calls, we considered the Traces filter's requirement in mind.

FYI - @vikrantgupta25

please create an issue for this. Atleast someday we will look into this

ankitnayan
ankitnayan previously approved these changes Sep 9, 2024
@SagarRajput-7
Copy link
Contributor

Here - #5900

SagarRajput-7
SagarRajput-7 previously approved these changes Sep 9, 2024
YounixM
YounixM previously approved these changes Sep 10, 2024
@ankitnayan
Copy link
Collaborator

@ahmadshaheer the build needs to be fixed for this to merge, right?

@ahmadshaheer ahmadshaheer merged commit 2cc2a43 into develop Sep 11, 2024
12 of 13 checks passed
@vikrantgupta25 vikrantgupta25 deleted the feat/add-environment-as-fast-filter-to-traces-page branch September 11, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants