Fix issue with importing new dashboard JSON files/creating new dashboards #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
abhi12299
force-pushed
the
fix-rgl-dashboard-error
branch
from
1dd4945
to
117ea50
Compare
|
@YounixM please review |
YounixM
force-pushed
the
fix-rgl-dashboard-error
branch
from
117ea50
to
d9a31e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
react-grid-layouterror when importing dashboard via JSON files or creating brand new dashboards.Describing the issue
From the docs of
react-grid-layouton npm, we either need to pass thelayoutprop directly to theGridLayoutcomponent or set thedata-gridattribute to each child of the grid. The issue was caused by setting both the props in theGridCardLayout.tsxcomponent.You can reproduce the issue by setting up a fresh installation of
signozand then trying to create a new dashboard.Issue:
issue_on_import.mov
issue_on_create.mov
Behaviour after fix:
fix.mov
Affected Areas and Manually Tested Areas
Dashboard layout component affected.