Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement quick filters for the new logs explorer page #5799

Merged
merged 29 commits into from
Sep 6, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Aug 29, 2024

Summary

Related Issues / PR's

fixes #3536

Screenshots

Screen.Recording.2024-09-02.at.10.58.29.PM.mov
Screen.Recording.2024-09-04.at.1.13.54.PM.mov

Affected Areas and Manually Tested Areas

  • different cases of logs explorer filters with sync and non synced versions
  • none of the changes translates to traces page and dashboards.

@github-actions github-actions bot added the enhancement New feature or request label Aug 29, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review September 2, 2024 17:31
@vikrantgupta25 vikrantgupta25 changed the title feat: implement logs quick filters for the new logs explorer page feat: implement quick filters for the new logs explorer page Sep 2, 2024
@ankitnayan
Copy link
Collaborator

Please include deployment.environment in the fast filters as Environment

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Selecting all back again doesn't (by manually checking boxing) not necessarily clears the filter always ( video attached)
  • Adding a filter like '=' manually and then trying to add from quick filter doesn't work always(video attached)
  • I am personally not convinced with how the quick filters work for multiple queries, either it should be all or a better way to let the user know that it is applied for this specific query. ( also where to click for that query to be highlited is a concern again)

--- design improvements

  • better way to let the user know that some filters in this query are added from quick filters ( eg some colour or something else)
Screen.Recording.2024-09-03.at.12.51.06.PM.mov
Screen.Recording.2024-09-03.at.12.53.57.PM.mov

@vikrantgupta25
Copy link
Collaborator Author

@GeekBoySupreme :- need your inputs for the design implications for the sync action

@vikrantgupta25
Copy link
Collaborator Author

@nityanandagohain

Selecting all back again doesn't (by manually checking boxing) not necessarily clears the filter always ( video attached)/'

expected behaviour as discussed on call. for the = and != operator i ll make the required changes

@vikrantgupta25
Copy link
Collaborator Author

@nityanandagohain made the changes for the = and != operator as well.

@GeekBoySupreme
Copy link
Collaborator

GeekBoySupreme commented Sep 3, 2024

@vikrantgupta25 not a lot of change from how you were showing the active query for applying fast filters.

Find the Figma here

image

The color of the query name on the fast filters sidebar should be the same as the color on the query stack and also on the right minimap.

image

Clicking on A or whichever is the active query name on the fast filters pane, you scroll to bring that specific query into focus from the query stack.

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '=', '!=' changes looks good but it has created a new bug, not sure if it's due to this,

The logs page now doesn't render correctly

image

a lot of space is left out below.

@vikrantgupta25
Copy link
Collaborator Author

@nityanandagohain @GeekBoySupreme addressed the issues and the design changes

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is some css edge case, please add a fix for it

Screen.Recording.2024-09-04.at.8.47.02.PM.mov

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have tested this earlier, but selecting an existing view and then apply filters the frontend crashes.

image

@vikrantgupta25 vikrantgupta25 merged commit 4a9847a into develop Sep 6, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the logs-quick-filter branch September 6, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs] Ability to apply filters quickly
7 participants