-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement quick filters for the new logs explorer page #5799
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Please include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Selecting all back again doesn't (by manually checking boxing) not necessarily clears the filter always ( video attached)
- Adding a filter like '=' manually and then trying to add from quick filter doesn't work always(video attached)
- I am personally not convinced with how the quick filters work for multiple queries, either it should be all or a better way to let the user know that it is applied for this specific query. ( also where to click for that query to be highlited is a concern again)
--- design improvements
- better way to let the user know that some filters in this query are added from quick filters ( eg some colour or something else)
Screen.Recording.2024-09-03.at.12.51.06.PM.mov
Screen.Recording.2024-09-03.at.12.53.57.PM.mov
@GeekBoySupreme :- need your inputs for the design implications for the sync action |
expected behaviour as discussed on call. for the |
@nityanandagohain made the changes for the |
@vikrantgupta25 not a lot of change from how you were showing the active query for applying fast filters. The color of the query name on the fast filters sidebar should be the same as the color on the query stack and also on the right minimap. Clicking on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nityanandagohain @GeekBoySupreme addressed the issues and the design changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The is some css edge case, please add a fix for it
Screen.Recording.2024-09-04.at.8.47.02.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Related Issues / PR's
fixes #3536
Screenshots
Screen.Recording.2024-09-02.at.10.58.29.PM.mov
Screen.Recording.2024-09-04.at.1.13.54.PM.mov
Affected Areas and Manually Tested Areas