Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v4 logs query builder #5796

Closed
wants to merge 7 commits into from
Closed

Conversation

nityanandagohain
Copy link
Member

This PR is the first breakdown PR for #5555

Major changes in v4 with respect to v3 QB are

  • Resource filters are only applied to the resource table.
  • Support for __attrs attribute to search in all attributes
  • resource filters are optimised to used the n-gram index.
  • Attribute search is case sensitive, while resources and body search is case insensitive.

@github-actions github-actions bot added the enhancement New feature or request label Aug 29, 2024
@srikanthccv
Copy link
Member

Can you update the pkg/query-service/app/logs/v4/query_builder.go and .../json_filter to include only the changes that are specific to v4 and use the functions like orderBy, groupByAttrs, reduce, having (and everything else that doesn't change in v4) from v3 ?

@nityanandagohain
Copy link
Member Author

Have made the changes, orderBy was not possible as it was dependent on the name of the column which changed.

@nityanandagohain nityanandagohain marked this pull request as draft September 5, 2024 12:36
@nityanandagohain
Copy link
Member Author

closing in favour of this #5908

@srikanthccv srikanthccv deleted the feat/logs-v4-qb branch September 12, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants