feat: preference framework qs changes #5527

vikrantgupta25 · 2024-07-19T09:19:40Z

Summary

query service changes for preference framework

Related Issues / PR's

fixes #4796

Screenshots

NA

Affected Areas and Manually Tested Areas

github-actions · 2024-07-19T09:19:55Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ee/query-service/app/server.go

pkg/query-service/app/http_handler.go

pkg/query-service/app/preferences/model.go

pkg/query-service/app/http_handler.go

pkg/query-service/app/preferences/model.go

pkg/query-service/app/preferences/map.go

pkg/query-service/app/preferences/model.go

deploy/docker/clickhouse-setup/docker-compose-local.yaml

pkg/query-service/auth/jwt.go

pkg/query-service/app/http_handler.go

vikrantgupta25 added 4 commits July 19, 2024 00:43

feat: query service changes base setup for preferences

99fd7a5

feat: added handlers for user and org preferences

3c2fd30

chore: added base for all user and all org preferences

7d7c74a

feat: added handlers for all user and all org preferences

936b3c4

github-actions bot added the enhancement New feature or request label Jul 19, 2024

vikrantgupta25 added 7 commits July 19, 2024 14:50

Merge branch 'develop' into preference-framework-qs

5aac0b2

feat: register the preference routes and initDB in pkg/query-service

59a5525

feat: code refactor

8615b38

chore: too much fun code refactor

1cc02b8

chore: little little missing attributes

d4cd28b

fix: handle range queries better

0f50e9b

fix: handle range queries better

d163b25

grandwizard28 requested changes Jul 21, 2024

View reviewed changes

vikrantgupta25 added 2 commits July 22, 2024 17:31

chore: address review comments

cb95946

Merge remote-tracking branch 'origin' into preference-framework-qs

ee2cf64

grandwizard28 requested changes Jul 22, 2024

View reviewed changes

pkg/query-service/app/http_handler.go Outdated Show resolved Hide resolved

pkg/query-service/app/http_handler.go Outdated Show resolved Hide resolved

chore: use struct inheritance for the all preferences struct

c4d1a4e

grandwizard28 requested changes Jul 22, 2024

View reviewed changes

pkg/query-service/app/preferences/model.go Outdated Show resolved Hide resolved

pkg/query-service/app/preferences/model.go Outdated Show resolved Hide resolved

pkg/query-service/app/preferences/model.go Outdated Show resolved Hide resolved

vikrantgupta25 added 5 commits July 23, 2024 14:53

chore: address review comments

b3c8344

Merge branch 'develop' into preference-framework-qs

5c0a167

chore: address review comments

10fd902

chore: correct preference routes

f0b68da

chore: low hanging optimisations

537abfe

grandwizard28 previously approved these changes Jul 23, 2024

View reviewed changes

vikrantgupta25 marked this pull request as ready for review July 23, 2024 10:35

vikrantgupta25 added the DO NOT MERGE label Jul 23, 2024

vikrantgupta25 requested a review from srikanthccv July 23, 2024 14:52

srikanthccv reviewed Jul 23, 2024

View reviewed changes

chore: address review comments

849c44a

vikrantgupta25 dismissed grandwizard28’s stale review via 849c44a July 23, 2024 17:27

vikrantgupta25 added 3 commits July 23, 2024 22:59

chore: address review comments

d424299

Merge branch 'develop' into preference-framework-qs

772b081

chore: added extra validations for the check in allowed values

a6862ee

srikanthccv previously approved these changes Jul 24, 2024

View reviewed changes

vikrantgupta25 dismissed srikanthccv’s stale review via d4d36a2 July 25, 2024 09:01

vikrantgupta25 requested a review from prashant-shahi as a code owner July 25, 2024 09:01

prashant-shahi reviewed Jul 25, 2024

View reviewed changes

deploy/docker/clickhouse-setup/docker-compose-local.yaml Outdated Show resolved Hide resolved

vikrantgupta25 force-pushed the preference-framework-qs branch from 58bf846 to a6862ee Compare July 25, 2024 12:03

grandwizard28 previously approved these changes Jul 25, 2024

View reviewed changes

srikanthccv previously approved these changes Jul 25, 2024

View reviewed changes

fix: better handling for the jwt claims

ff03eab

vikrantgupta25 dismissed stale reviews from srikanthccv and grandwizard28 via ff03eab July 26, 2024 08:22

vikrantgupta25 added 2 commits July 26, 2024 13:53

fix: better handling for the jwt claims

b150021

Merge branch 'develop' into preference-framework-qs

56bd342

vikrantgupta25 commented Jul 26, 2024

View reviewed changes

pkg/query-service/auth/jwt.go Outdated Show resolved Hide resolved

vikrantgupta25 removed the DO NOT MERGE label Jul 26, 2024

vikrantgupta25 added 2 commits July 27, 2024 10:38

chore: move the error to preference apis

d02b118

chore: move the error to preference apis

669729d

vikrantgupta25 commented Jul 27, 2024

View reviewed changes

pkg/query-service/auth/jwt.go Show resolved Hide resolved

vikrantgupta25 commented Jul 27, 2024

View reviewed changes

pkg/query-service/app/http_handler.go Show resolved Hide resolved

vikrantgupta25 added 2 commits July 27, 2024 10:58

Merge branch 'develop' into preference-framework-qs

2c5dc4c

fix: move the 401 logic to the auth middleware

61ea836

srikanthccv approved these changes Jul 27, 2024

View reviewed changes

vikrantgupta25 merged commit d00024b into develop Jul 29, 2024
12 checks passed

vikrantgupta25 deleted the preference-framework-qs branch July 29, 2024 04:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: preference framework qs changes #5527

feat: preference framework qs changes #5527

vikrantgupta25 commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024

feat: preference framework qs changes #5527

feat: preference framework qs changes #5527

Conversation

vikrantgupta25 commented Jul 19, 2024 • edited Loading

Summary

Related Issues / PR's

Screenshots

Affected Areas and Manually Tested Areas

github-actions bot commented Jul 19, 2024

vikrantgupta25 commented Jul 19, 2024 •

edited

Loading