-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: QS package for integrations #4578
Conversation
cf05609
to
5c792a3
Compare
WalkthroughThe update introduces a comprehensive framework for managing integrations within the query service application. It encompasses the creation of a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (6)
- pkg/query-service/app/integrations/Readme.md (1 hunks)
- pkg/query-service/app/integrations/manager.go (1 hunks)
- pkg/query-service/app/integrations/manager_test.go (1 hunks)
- pkg/query-service/app/integrations/repo.go (1 hunks)
- pkg/query-service/app/integrations/sqlite_repo.go (1 hunks)
- pkg/query-service/app/integrations/test_utils.go (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- pkg/query-service/app/integrations/Readme.md
- pkg/query-service/app/integrations/manager.go
- pkg/query-service/app/integrations/manager_test.go
- pkg/query-service/app/integrations/repo.go
- pkg/query-service/app/integrations/sqlite_repo.go
- pkg/query-service/app/integrations/test_utils.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- pkg/query-service/app/integrations/manager.go (1 hunks)
- pkg/query-service/app/integrations/manager_test.go (1 hunks)
- pkg/query-service/app/integrations/test_utils.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- pkg/query-service/app/integrations/manager.go
- pkg/query-service/app/integrations/manager_test.go
- pkg/query-service/app/integrations/test_utils.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Gets the query-service/app/integrations/... package started with integrations.Manager.
This code is expected to evolve further as other pieces of the integration picture get fleshed out.
Up next:
[ ] wiring up of pipelines for installed integrations.
[ ] exposing integrations manager through query service web API for use in UI
[ ] add more integration assets (dashboards, alerts, saved views...)
Related Issues / PR's
Contributes to #4462
Affected Areas and Manually Tested Areas
None. The integrations package is yet to be wired up with live features.
Summary by CodeRabbit