Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 👷 pin Go v1.21 and bump up actions/* in GH build/push workflows #3687

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

prashant-shahi
Copy link
Member

Ref: https://github.com/actions/setup-go

Signed-off-by: Prashant Shahi prashant@signoz.io

Signed-off-by: Prashant Shahi <prashant@signoz.io>
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

srikanthccv
srikanthccv previously approved these changes Oct 8, 2023
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test out the changes on your fork before submitting the PR so that we can avoid these series of PRs that are trying to fix the workflow.

@srikanthccv srikanthccv dismissed their stale review October 8, 2023 14:11

Please show that it's actually fixes the issue and will approve again.

srikanthccv and others added 2 commits October 8, 2023 14:12
@prashant-shahi prashant-shahi changed the title ci: 👷 pin Go v1.21 in GH build/push workflows ci: 👷 pin Go v1.21 and bump up actions/* in GH build/push workflows Oct 8, 2023
@prashant-shahi
Copy link
Member Author

@srikanthccv Verified the working of the PR changes.

Tested workflow job: https://github.com/prashant-shahi/signoz/actions/runs/6448877140
BE Images built: https://hub.docker.com/r/coolboi567/query-service/tags

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@prashant-shahi prashant-shahi merged commit b14f800 into develop Oct 8, 2023
@prashant-shahi prashant-shahi deleted the ci/go-version branch October 8, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants