Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce feature_usage table to manage features #2661

Merged
merged 16 commits into from
May 17, 2023
Merged

feat: introduce feature_usage table to manage features #2661

merged 16 commits into from
May 17, 2023

Conversation

makeavish
Copy link
Member

No description provided.

@request-info
Copy link

request-info bot commented May 3, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions github-actions bot added the enhancement New feature or request label May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@makeavish makeavish marked this pull request as ready for review May 4, 2023 04:06
@makeavish makeavish requested a review from srikanthccv as a code owner May 4, 2023 04:06
@makeavish makeavish requested a review from srikanthccv May 16, 2023 10:23
@srikanthccv srikanthccv requested a review from ankitnayan May 16, 2023 14:24
srikanthccv
srikanthccv reviewed May 17, 2023
View reviewed changes
@makeavish makeavish requested a review from srikanthccv May 17, 2023 09:15
srikanthccv
srikanthccv reviewed May 17, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mainly the update usage limit error part.

makeavish and others added 2 commits May 17, 2023 15:14
@makeavish @srikanthccv
Update ee/query-service/license/manager.go
6cce813 
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@makeavish
chore: improve error handling
67bd775
@makeavish makeavish requested a review from srikanthccv May 17, 2023 10:14
srikanthccv
srikanthccv approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue for the items you mentioned to address later. I assume this is tested thoroughly.

@makeavish makeavish merged commit c32b863 into develop May 17, 2023
@makeavish makeavish deleted the feat/usage-limit branch May 17, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees
No one assigned
Labels
codeball:needs-careful-review Codeball enhancement New feature or request request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makeavish @srikanthccv @palashgdev