feat: Filter spans using regex pattern matching in tags #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#222
This is not the complete solution. Some refactoring, improvements and support in druid setup is pending. I wanted to get an initial feedback for this.
So I think there are 2 ways to do this.
We create one more operator
Pattern
in which we give an option to user to select out of (1xx, 2xx, 3xx, 4xx, 5xx), so that we don't get unexpected patterns. This requires little frontend work.We implicitly support it from the backend like I have sort of done in this change. If a user passes 4xx, he/she will get response accordingly.
IMO both are okay, but intuitively would it make more sense to have an explicit operator so that user is sure and know exactly what he/she are searching.
Let me know your thoughts @ankitnayan