Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ch query support #1735

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

mindhash
Copy link
Contributor

This PR introduces:

  • changes to support ch queries in alert form

References:
Issue# 1699
PRD

srikanthccv
srikanthccv previously approved these changes Nov 23, 2022
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindhash, you mentioned some variables to rename to _nano to make it clear. I believe you are planning to do that in this PR itself. Otherwise LGTM.

pkg/query-service/app/http_handler.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

@ankitnayan ankitnayan merged commit 00863e5 into SigNoz:develop Nov 23, 2022
YounixM pushed a commit that referenced this pull request Sep 2, 2024
* feat: add view templates option to dashboard menu

* feat: increase dropdown overlay width
Set the dropdown overlay width to 200px to provide breathing space for the dropdown button.
Added flex to wrap the dropdown button to create space between the right icon and the left elements.

* feat: add localization for messaging queues Kafka overview page

Added localization support for the messaging queues Kafka overview page.

Closes #1735

---------

Co-authored-by: Pranay Prateek <pranay@signoz.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants