Skip to content

[API-7661] Adds support for warnings in Events API response #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2024

Conversation

iprysiazhnyi-sift
Copy link
Contributor

@iprysiazhnyi-sift iprysiazhnyi-sift commented May 28, 2024

Purpose

Events API started to support new fields param warnings to represent any warning in the response object

Summary

Adds optional field include_warnings to track method

Testing

Local testing. Additionally covered with unit/integration tests

Checklist

  • The change was thoroughly tested manually
  • The change was covered with unit tests
  • The change was tested with real API calls (if applicable)
  • Necessary changes were made in the integration tests (if applicable)
  • New functionality is reflected in README

README.md Outdated
Comment on lines 238 to 241
To include `warnings` field to Events API response via calling `track()` method, set it by the `include_warnings` param:
```python
response = client.track("$transaction", properties, include_warnings=True)
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this section right after include_score_percentiles to keep all client.track docs at the same place?

@iprysiazhnyi-sift iprysiazhnyi-sift merged commit 065ae94 into master May 31, 2024
3 checks passed
@iprysiazhnyi-sift iprysiazhnyi-sift deleted the API-7661 branch May 31, 2024 09:26
@iprysiazhnyi-sift iprysiazhnyi-sift mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants