[MSUE-129] - Updates in the lib #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viaskal-sift
reviewed
Dec 5, 2022
src/test/java/com/siftscience/BaseAppBrowserSiteBrandFieldSetTest.java
Outdated
Show resolved
Hide resolved
mpierotti-sift
left a comment
mpierotti-sift
left a comment
There was a problem hiding this comment.
Left a comment about the user agent changes, looks good otherwise.
| @Expose @SerializedName("$user_agent") private String userAgent; | ||
| private static final String APP_VERSION = "3.7.0"; | ||
| private static final String API_VERSION = "v205"; | ||
| @Expose @SerializedName("$user_agent") private String userAgent = String.format("SiftScience/%s sift-java/%s", API_VERSION, APP_VERSION); |
There was a problem hiding this comment.
I don't think this change is correct for MSUE-63: (Java) Set user Agent String to Client to identifiable value. The SDK user agent should be set in the headers of the the requests that the OkHttpClient is making to Sift, but this implementation seems to be changing the default value for Browser json data within the request.
Contributor
Author
There was a problem hiding this comment.
Hi @mpierotti-sift Could you please take a look now? Incorporated changes as suggested.
viaskal-sift
reviewed
Dec 8, 2022
viaskal-sift
reviewed
Dec 8, 2022
viaskal-sift
reviewed
Dec 8, 2022
sbogolii-sift
suggested changes
Dec 12, 2022
sbogolii-sift
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://sift.atlassian.net/browse/MSUE-129
changes: