Skip to content

Conversation

@rsomavarapu-sift
Copy link
Contributor

Purpose:
Capture travel and ticketing specific data by providing additional fields in the API. Here is the spec.

Technical overview:

  • Add support for the new booking fields in $create_order and $update_order events

Testing Plan:

  • Updated unit tests
  • Send sample events using SiftClient to experiment environment and verify the changes using the experiment console.

Deployment:
will publish to Maven
Github release
(after the code changes for $bookings object are deployed)

@rsomavarapu-sift rsomavarapu-sift requested a review from ehrmann July 1, 2019 17:41
@rsomavarapu-sift
Copy link
Contributor Author

@rsomavarapu-sift rsomavarapu-sift changed the title (For David) adding support for complex field in and events (For David) adding support for bookings complex field in $create_order and $update_order events Jul 1, 2019
@rsomavarapu-sift rsomavarapu-sift force-pushed the travel_and_ticketing_api branch from cd5c90b to d02be8b Compare July 1, 2019 21:00
@rsomavarapu-sift
Copy link
Contributor Author

experiment console outputs for $create_order and $update_order events with updated field naming for $departure_location and $arrival_location (updated to $departure_address and $arrival_address)

$create_order
Request Body: https://gist.github.com/rsomavarapu-sift/09f60e19c758e6b017e4bb8d01ec9cff
Response Body: https://gist.github.com/rsomavarapu-sift/d505b110e62ba8b886c53146be06863f

$update_order
Request Body: https://gist.github.com/rsomavarapu-sift/4d7dc46eb392e9ef833e262f5dff2f68
Response Body: https://gist.github.com/rsomavarapu-sift/0e35e795f2b5c7e7be313cc36eeddb81

@rsomavarapu-sift rsomavarapu-sift merged commit fafa950 into master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants