-
Notifications
You must be signed in to change notification settings - Fork 7
chore(deps): Bump human-errors from 0.1.5 to 0.2.2 #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [human-errors](https://github.com/SierraSoftworks/human-errors-rs) from 0.1.5 to 0.2.2. - [Release notes](https://github.com/SierraSoftworks/human-errors-rs/releases) - [Commits](SierraSoftworks/human-errors-rs@v0.1.5...v0.2.2) --- updated-dependencies: - dependency-name: human-errors dependency-version: 0.2.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
notheotherben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving dependency upgrades.
|
@copilot please put together a PR switching to v0.2.2 of Beforeuse human_errors;
use std::fs;
human_errors::error_shim!(MyError);
fn read_config() -> Result<String, MyError> {
fs::read_to_string("config.toml").map_err(|err| {
user_with_internal(
"We could not read the configuration file.",
"Make sure that you've specified a valid config file with the --config option.",
err
)
})
}Afteruse human_errors::ResultExt;
use std::fs;
fn read_config() -> Result<String, human_errors::Error> {
fs::read_to_string("config.toml").wrap_err_as_user(
"We could not read the configuration file.",
&["Make sure that you've specified a valid config file with the --config option."])
} |
|
@notheotherben I've opened a new pull request, #1677, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: notheotherben <1760260+notheotherben@users.noreply.github.com>
- Removed wrapper functions from errors/mod.rs - Updated all error conversion modules to use human_errors directly - Replaced all errors::user/system calls with human_errors::user/system - Replaced errors::user_with_internal/system_with_internal with human_errors::wrap_user/wrap_system - Added StringError helper type for string-based error causes - Converted advice parameters to static string arrays &[&str] - Rewrote dynamic advice messages to include context in error message itself This follows the guidance from SierraSoftworks/github-backup#453 where dynamic content is moved from advice to the main error message. Co-authored-by: notheotherben <1760260+notheotherben@users.noreply.github.com>
Fixed multiple syntax issues introduced during automated refactoring: - Fixed mismatched parentheses and braces - Corrected format! macro calls - Rewrote dynamic advice messages to be static - Merged dynamic context into main error messages Most syntax errors resolved. A few edge cases remain in resolver.rs. Co-authored-by: notheotherben <1760260+notheotherben@users.noreply.github.com>
Removed StringError wrapper as strings can be passed directly to human_errors functions. - Deleted StringError type definition from errors/mod.rs - Replaced all errors::StringError::new(...) with direct string values - Fixed several syntax errors from previous automated refactoring Addresses feedback in comment 3706408749. Co-authored-by: notheotherben <1760260+notheotherben@users.noreply.github.com>
- Fixed malformed format! calls and mismatched braces - Reverted heavily damaged files to clean state for proper migration - Ready to apply human_errors API changes cleanly Addresses the new requirement to use ResultExt methods. Co-authored-by: notheotherben <1760260+notheotherben@users.noreply.github.com>
Migrate to human-errors v0.2.2 direct API usage
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
+ Coverage 85.34% 88.04% +2.70%
==========================================
Files 98 99 +1
Lines 7971 7840 -131
==========================================
+ Hits 6803 6903 +100
+ Misses 1168 937 -231
🚀 New features to boost your workflow:
|
Bumps human-errors from 0.1.5 to 0.2.2.
Release notes
Sourced from human-errors's releases.
... (truncated)
Commits
1a0263eMerge pull request #33 from SierraSoftworks/feat/cli-rendering69912ccstyle: Fix formatting4279218ci: Enable testing of code changes710c373tweak: Rename feature to "pretty"c92c35edocs: Improve documentation for use of pretty printing4487e05style: Resolve clippy warnings49ccacastyle: Format code with cargo fmt8df7d66feat: Add support for rendering a pretty error to the CLI9c1f84etweak: Adjust the formatting of user and system error descriptionsdc77ae4style: Rearrange the code slightlyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)