Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - Replaced LG Dialog with Bottom Sheet and Side Sheet #14

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Enhancement - Replaced LG Dialog with Bottom Sheet and Side Sheet #14

merged 4 commits into from
Oct 11, 2023

Conversation

dharamveer-gupta
Copy link
Contributor

@dharamveer-gupta dharamveer-gupta commented Oct 9, 2023 •
edited
Loading

Can you please tag this issue as hactoberfest?

Task Done -

  • BottomSheet Dialog (Portrait Mode on Mobile device)
  • SideSheet Dialog (Tablet & Landscape mode on Mobile device)

Before Enhancement ScreenShots -

  • LG Dialog on Mobile device - (Portrait Mode)
image image
  • LG Dialog on Mobile device - (Landscape Mode)
image
  • LG Dialog Dialog on Tablet device - (Portrait Mode)
image image
  • LG Dialog Dialog on Tablet device - (Landscape Mode)
image image

After Enhancement ScreenShots -

  • BottomSheet Dialog on Mobile device - (Portrait Mode)
image image
  • SideSheet Dialog on Mobile device - (Landscape Mode)
image image
  • SideSheet Dialog on Tablet device - (Portrait Mode)
image image
  • SideSheet Dialog on Tablet device - (Landscape Mode)
image image

@dharamveer-gupta
SidharthMudgil#4 Enhancement: Replaced LG Dialog with Bottom Sheet an…
cba37ee 
…d Side Sheet Dialogs (for both Tablet device and Landscape mode on mobile device)
@dharamveer-gupta
SidharthMudgil#4 Enhancement: Replaced LG Dialog with Bottom Sheet an…
80f5129 
…d Side Sheet Dialogs (for both Tablet device and Landscape mode on mobile device), also optimised w.r.t. both light & dark theme.
@dharamveer-gupta
Merge remote-tracking branch 'origin/enhancement-replace-lg-dialog-wi…
bef31e9 
…th-bottom-sheet-and-side-sheet' into enhancement-replace-lg-dialog-with-bottom-sheet-and-side-sheet

# Conflicts:
#	app/src/main/res/layout-land/connection_dialog.xml
#	app/src/main/res/layout-sw600dp/connection_dialog.xml
#	app/src/main/res/layout/connection_dialog.xml
@SidharthMudgil
Copy link
Owner

Why nav rail is not centred in tab layout... Did you change it?

@dharamveer-gupta
Copy link
Contributor Author

dharamveer-gupta commented Oct 10, 2023 •
edited
Loading

Why nav rail is not centred in tab layout... Did you change it?

No I haven't, Nav rail is untouched.
Even I also noticed the same for tablet device in the main branch

For mobile landscape mode, it was already vertically centred.

@SidharthMudgil
Copy link
Owner

can you increase width of the side sheet for tablets... increase around 1.5x

@dharamveer-gupta
Copy link
Contributor Author

can you increase width of the side sheet for tablets... increase around 1.5x

Below are the screenshot after increasing width of SideSheet around 1.5x for both Tablet & Mobile devices?

  1. on Mobile device after increasing it to 1.5x width of SideSheet (Landscape mode)
image
  1. on Tablet device after increasing it to 1.5x width of SideSheet (Portrait mode)
image
  1. on Tablet device after increasing it to 1.5x width of SideSheet (Landscape mode)
image

@SidharthMudgil SidharthMudgil merged commit d8600bf into SidharthMudgil:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dharamveer-gupta @SidharthMudgil