Pause and Ended Shows delay, xhtml_unescape #8507

BKSteve · 2023-07-20T15:36:30Z

Proposed changes in this pull request:

Put configuration of days delay to ended show below the hour to check show updates. Add some detail to notes.
Include paused with ended in delay usage
Fixed language identification code by .decode when adding show

minor logging text fixes to mediabrowser and tivo

sickchill/views/manage/add_shows.py

This sanitizes and decodes arguments to unicode that are passed in web requests to the server Also, added logging for developers for all web routes when they have parameters defined in the method signature when they shouldn't be. Each method should explicitly use get_*_argument(s) methods to ensure passed data is safe and sanitized, devoid of control characters, injection safe, and formatted in the correct type. All route methods should only have `self` as a parameter, suck as `def searchIndexersForShowName(self): lang = self.get_argument("lang", strip=True)`

…ows.py get_*_argument(s) methods return body/query arguments percent-decoded, decoded to unicode, and sanitized with control characters and other unsafe characters removed.

miigotu · 2023-07-22T03:19:21Z

I got a bunch of it done. I'm going to try and do these other instances, and also unquote/unquote_plus that is used on route arguments (I don't want to go backwards to what was used before, it's what caused password encoding problems, show dir problems, etc and was hard to track down)

Before other routes are updated to use the correct argument handling, these need gone over (I'll try to do them tonight):
https://photos.app.goo.gl/HhRx8XnpoJjKL8KT7

BKSteve · 2023-07-22T11:34:02Z

They killed the processing. The items with the changes in index were nolonger byte strings see
https://discord.com/channels/502612977271439372/1132179311223373907
where I was journaling the testing.

Signed-off-by: miigotu <miigotu@gmail.com>

This sanitizes and decodes arguments to unicode that are passed in web requests to the server Also, added logging for developers for all web routes when they have parameters defined in the method signature when they shouldn't be. Each method should explicitly use get_*_argument(s) methods to ensure passed data is safe and sanitized, devoid of control characters, injection safe, and formatted in the correct type. All route methods should only have `self` as a parameter, suck as `def searchIndexersForShowName(self): lang = self.get_argument("lang", strip=True)`

…ows.py get_*_argument(s) methods return body/query arguments percent-decoded, decoded to unicode, and sanitized with control characters and other unsafe characters removed.

BKSteve · 2023-07-29T13:33:35Z

The IMDbPY isn't being updated so changed to Cinemagoer 2023.5.1 in
bunch of _sr_ to _sc_
Added g to replaceAll in core.js 428 - now #2 is displayed when adding shows. (steep learning curve).

now with add existing a more interesting item.

2023-07-29 20:39:44 DEBUG :: WEBSERVER-ADDSHOWS_0 :: Searching for Show with search term(s): ['Around the World in 80 Days'] on Indexer: theTVDB (exact: False)

Edit 20230730:
See Dateutil Rabbit Hole resolving shows with names that get interpreted as dates.
Haven't followed further with IMDB adding and went for Trakt.

BKSteve · 2023-07-30T13:46:41Z

When working on the trakt add show issue I note the directory and options settings no longer show at top of screen.

This proves to be an issue as the cur_dir isn't known and thus the add process gets stuck.
Edit: truncated as not needed

miigotu · 2023-07-31T13:36:27Z

Yeah I don't want to add that code back. I'm in the middle of completely rewriting how trending and favorite and popular shows are added. They used to use a different method, I'm changing it to use new show directly and combining those 3 pages into 1.

BKSteve · 2023-07-31T16:05:04Z

OK, will step back from this area for a couple of days.

Signed-off-by: miigotu <miigotu@gmail.com>

…d and a notifier Signed-off-by: miigotu <miigotu@gmail.com>

…hed and make code easier to maintain Signed-off-by: miigotu <miigotu@gmail.com>

miigotu · 2023-08-06T03:05:05Z

I messed up in a few places in the last 3 commits where if s is not None: went to if season:, the is not None needs to stay on that for season and episode.

miigotu · 2023-08-06T03:08:15Z

I also still have to fix the add shows. If you want, you could check the add existing and normal show adding. I'll worry about the IMDb/trakt/popular lists.

…alidly 0 Signed-off-by: miigotu <miigotu@gmail.com>

sickchill/gui/slick/views/testRename.mako

refactor variable and move more python out of the template Signed-off-by: miigotu <miigotu@gmail.com>

…fault use get_query_argument for refreshShow, updateShow, testRename Signed-off-by: miigotu <miigotu@gmail.com>

Signed-off-by: miigotu <miigotu@gmail.com>

BKSteve · 2023-08-07T13:31:14Z

If you want, you could check the add existing and normal show adding.

Tested. Functional.
All show functions; Add, Add Existing (single and multiple), and all internal show edit items working.

Add: Mass Update not ok (expected)

miigotu · 2023-08-08T05:12:10Z

What is wrong with mass update?

Pause and Ended Shows same delay.

488309a

miigotu reviewed Jul 20, 2023

View reviewed changes

sickchill/views/manage/add_shows.py Outdated Show resolved Hide resolved

BKSteve and others added 4 commits July 21, 2023 21:19

Add show unescape

5b097f8

use get_argument instead of xhtml_unescape and unquote_plus in add_sh…

c0e2910

…ows.py get_*_argument(s) methods return body/query arguments percent-decoded, decoded to unicode, and sanitized with control characters and other unsafe characters removed.

Update index.py

ced8b26

miigotu and others added 4 commits July 21, 2023 23:19

Merge branch 'develop' into paused

d567c81

format index.py

52fff32

format add_shows.py

cc18ee8

Add show filter work

f322e0f

BKSteve changed the title ~~Pause and Ended Shows same delay.~~ Pause and Ended Shows delay, xhtml_unescape Jul 22, 2023

This comment was marked as outdated.

Sign in to view

Update index.py

9bd5f05

miigotu and others added 15 commits July 22, 2023 08:15

Update add_shows.py

912d8e9

Update index.py

878d6f9

Update rootDirs.js

f62f8c8

fix formatting

e490f65

Signed-off-by: miigotu <miigotu@gmail.com>

Pause and Ended Shows same delay.

4b85785

Add show unescape

66422a2

use get_argument instead of xhtml_unescape and unquote_plus in add_sh…

beff4c1

…ows.py get_*_argument(s) methods return body/query arguments percent-decoded, decoded to unicode, and sanitized with control characters and other unsafe characters removed.

Update index.py

98dcf3a

format index.py

964e41b

format add_shows.py

1bf618f

Add show filter work

8f62d0e

Update index.py

9add823

Update add_shows.py

d308b07

Update index.py

f48d925

BKSteve added 2 commits July 29, 2023 20:30

sr - sc metadata, replaceAll /g, cinemagoer

ade60a0

replaceAll /g

71f5780

BKSteve added 3 commits July 29, 2023 21:30

Cinemagoer load location

c2680b5

Dateutil Rabbit Hole.

91f0910

trakt addshow

f6c6ce5

BKSteve and others added 5 commits August 1, 2023 20:33

addshow extra logs cleanout

f007d8b

imageSelector.py escape regex #8506

e71adb2

rename variable in show_queue from newShow to new_show

40b1941

Signed-off-by: miigotu <miigotu@gmail.com>

try to clean up trakt further, its a huge mess having a checker threa…

42644dc

…d and a notifier Signed-off-by: miigotu <miigotu@gmail.com>

more refactoring, rename variables to be more readable and distinguis…

484384c

…hed and make code easier to maintain Signed-off-by: miigotu <miigotu@gmail.com>

fix error with is not None for season and episode, they can both be v…

da60383

…alidly 0 Signed-off-by: miigotu <miigotu@gmail.com>

BKSteve commented Aug 6, 2023

View reviewed changes

sickchill/gui/slick/views/testRename.mako Show resolved Hide resolved

BKSteve commented Aug 6, 2023

View reviewed changes

sickchill/gui/slick/views/testRename.mako Show resolved Hide resolved

BKSteve and others added 3 commits August 6, 2023 21:50

location and pytivo minor items

60152de

fix issue with x format in testRename

c6a140b

refactor variable and move more python out of the template Signed-off-by: miigotu <miigotu@gmail.com>

remove unnecessary strip from get_*_argument calls, as True is the de…

5417f37

…fault use get_query_argument for refreshShow, updateShow, testRename Signed-off-by: miigotu <miigotu@gmail.com>

miigotu force-pushed the paused branch from 4d74f13 to 5417f37 Compare August 7, 2023 01:22

miigotu added 2 commits August 6, 2023 21:25

fix build, js replaceAll without special regex doesnt need a regex

c563d68

Signed-off-by: miigotu <miigotu@gmail.com>

Merge branch 'develop' into paused

cfbd545

Merge branch 'develop' into paused

f8565f1

miigotu merged commit 06bf481 into develop Aug 8, 2023
11 checks passed

miigotu deleted the paused branch August 8, 2023 02:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pause and Ended Shows delay, xhtml_unescape #8507

Pause and Ended Shows delay, xhtml_unescape #8507

BKSteve commented Jul 20, 2023 •

edited

Loading

miigotu commented Jul 22, 2023

This comment was marked as outdated.

BKSteve commented Jul 22, 2023

BKSteve commented Jul 29, 2023 •

edited

Loading

BKSteve commented Jul 30, 2023 •

edited

Loading

miigotu commented Jul 31, 2023

BKSteve commented Jul 31, 2023

miigotu commented Aug 6, 2023

miigotu commented Aug 6, 2023

BKSteve commented Aug 7, 2023 •

edited

Loading

miigotu commented Aug 8, 2023

Pause and Ended Shows delay, xhtml_unescape #8507

Pause and Ended Shows delay, xhtml_unescape #8507

Conversation

BKSteve commented Jul 20, 2023 • edited Loading

miigotu commented Jul 22, 2023

This comment was marked as outdated.

BKSteve commented Jul 22, 2023

BKSteve commented Jul 29, 2023 • edited Loading

BKSteve commented Jul 30, 2023 • edited Loading

miigotu commented Jul 31, 2023

BKSteve commented Jul 31, 2023

miigotu commented Aug 6, 2023

miigotu commented Aug 6, 2023

BKSteve commented Aug 7, 2023 • edited Loading

miigotu commented Aug 8, 2023

BKSteve commented Jul 20, 2023 •

edited

Loading

BKSteve commented Jul 29, 2023 •

edited

Loading

BKSteve commented Jul 30, 2023 •

edited

Loading

BKSteve commented Aug 7, 2023 •

edited

Loading