Databases should be password-protected (java:S2115) #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add user and password to the RAKIP vocabularies database. ## java:S2115 Databases should always be password protected. The use of a database connection with an empty password is a clear indication of a database that is not protected. This rule flags database connections with empty passwords.
schuelet
approved these changes
Nov 6, 2020
|
There is a conflict but FskService is also changed in #715. I will wait for that PR to be merged before fixing the conflict here. |
schuelet
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user and password to the RAKIP vocabularies database.
java:S2115
Databases should always be password protected. The use of a database
connection with an empty password is a clear indication of a database
that is not protected.
This rule flags database connections with empty passwords.