Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. #4

Closed
VishalPeruma1 opened this issue Feb 11, 2024 · 0 comments
Closed

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. #4

VishalPeruma1 opened this issue Feb 11, 2024 · 0 comments
Assignees
@VishalPeruma1
Labels
Group 12 Technical Debt
Milestone
Case Study 1

Comments

@VishalPeruma1
Copy link
Collaborator

Screenshot 2024-02-11 135655

Description of Technical Debt:
The function is empty as there is no need for the ClockViewHolder to update its view every time there is a change. An empty method is generally considered bad practice and can lead to confusion, readability, and maintenance issues. To remedy that we give a comment explaining why it is empty.

Technical Debt Location
src/main/java/de/dennisguse/opentracks/viewmodels/ClockViewHolder.java
@VishalPeruma1 VishalPeruma1 added this to the Case Study 1 milestone Feb 11, 2024
VishalPeruma1 added a commit that referenced this issue Feb 11, 2024
@VishalPeruma1
Fixing issue #4
4883bb2
@VishalPeruma1 VishalPeruma1 mentioned this issue Feb 11, 2024
Merged
VishalPeruma1 added a commit that referenced this issue Feb 11, 2024
@VishalPeruma1
Merge pull request #6 from Shrutipavasiya/dev/vishal
bc13986 
fix: issue #4, adding comment to empty class.
@VishalPeruma1 VishalPeruma1 self-assigned this Feb 11, 2024
parsa-mre pushed a commit that referenced this issue Apr 7, 2024
@JSM2512
Merge pull request #4 from JSM2512/Jaiwant
cbd65d6 
Removal of Empty statements in ChartView.java
parsa-mre pushed a commit that referenced this issue Apr 7, 2024
@navkamboj
#4 Added the missing @deprecated Javadoc
6d1633e
parsa-mre pushed a commit that referenced this issue Apr 7, 2024
@divawalazeel
Merge pull request #4 from tarekFerdous/zeel_ExportActivity
9745bc0 
Commiting my changes of the method
parsa-mre pushed a commit that referenced this issue Apr 7, 2024
@vaibhav-invictus
Issue #4 is solved by using a more specific exception, such as Unsupp…
003e56e 
…ortedOperationException.
parsa-mre pushed a commit that referenced this issue Apr 7, 2024
@vaibhav-invictus
Merge pull request #8 from Reva-B98/main_Vaibhav
d50e875 
Issue #4 is solved by using a more specific exception, such as Unsupp…
parsa-mre pushed a commit that referenced this issue Apr 7, 2024
@numanSlm
Merge pull request #4 from numanSlm/branch_Yug
ddc7812 
Replace "replaceAll()" by a call to the "replace()" method.
VishalPeruma1 pushed a commit that referenced this issue Apr 26, 2024
@vaibhav-invictus
Merge pull request #4 from gup-abhi/feature/add_labels_vaibhav
f8dfc9c 
Feature/add labels
VishalPeruma1 pushed a commit that referenced this issue Apr 26, 2024
@nihal514
Merge pull request #4 from aswiinraviprakash/nihal514-patch-5
e305d5a 
Added Shortest wait at chairlift Widget
VishalPeruma1 pushed a commit that referenced this issue Apr 26, 2024
@thanhpd
fix: fix build failures after sprint 2
1e107e1 
1. Updated string.xml to fix error in screenshot #1 (src\main\res\values\strings.xml)
2. Updated build.gradle to fix error in screenshot #2 (src\main\res\layout\fragment_runs_stat.xml)
3. Updated src\main\java\de\dennisguse\opentracks\stats\TrackStatisticsUpdater.java to fix error in screenshot #3
4. Commented out code in src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/SeasonStats/RunAndChairStatActivity.java and src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/SeasonStats/SeasonStatActivity.java to fix error in screenshot #4
5. Commented out code in  src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/AggregatedStatisticsAdapter.java to fix error in screenshot #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VishalPeruma1 VishalPeruma1

Labels
Group 12 Technical Debt
Projects
None yet
Milestone
Case Study 1
Development

No branches or pull requests
1 participant
@VishalPeruma1