Remove deprecated exports path mapping #323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was deprecated in node 16. See: https://nodejs.org/api/deprecations.html#DEP0148
|
Closing, didn't realise we had a PR already open for this. See #292 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Node versions prior to 16.x often used
"./"to allow deep package imports during the introduction of theexportsfield. Starting with node 16.x folder mappings are deprecated and should not be used.Related: preactjs/preact#3299
Solution
Drop the field, since it's deprecated and not necessary. Instead every package entry point should be explicitely declared via
exports.🎩
Checklist