Skip to content

Update navigateToPosScreen for tabs navigation #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

katriciab
Copy link
Contributor

@katriciab katriciab commented Jul 8, 2025

Background

Part of https://github.com/shop/issues-retail/issues/8201

This updates the navigateToPosScreen API so that we can also navigate to tabs in POS like Home/Cart.

Currently, this PR is off unstable branch so we can create a snapshot for the pos-next-react-native changes to point to while 2025-10-rc is not yet ready.

Solution

This is the API interface update, and should have enough comments to describe the pos screens and when we would throw an error.

Note: We have a task for this shopify-dev documentation and a PR will be up shortly once all our changes are ready.

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Copy link
Contributor Author

katriciab commented Jul 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@katriciab katriciab marked this pull request as ready for review July 8, 2025 19:27
@katriciab katriciab force-pushed the kat/ui-extension/navigate-to-tabs branch from e2f4526 to c607cea Compare July 8, 2025 19:41
@katriciab katriciab marked this pull request as draft July 8, 2025 22:34
@katriciab katriciab changed the base branch from 2025-10-rc to unstable July 8, 2025 22:39
@katriciab katriciab changed the base branch from unstable to 2025-10-rc July 8, 2025 22:40
@katriciab katriciab changed the base branch from 2025-10-rc to unstable July 8, 2025 22:43
@katriciab katriciab force-pushed the kat/ui-extension/navigate-to-tabs branch from c607cea to b73775a Compare July 8, 2025 22:43
@katriciab katriciab marked this pull request as ready for review July 8, 2025 22:51
@katriciab
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @katriciab! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/ui-extensions": "0.0.0-snapshot-20250708225244",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20250708225244"

Copy link
Contributor

@thunderfern thunderfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it also looks like there is some duplicate code between my previous PR and the PosScreenParams here. I assume some of those lines will no longer be new additions after this code is rebased on the 2025-10-rc branch.

@katriciab katriciab marked this pull request as draft July 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants