Update README.md - clarify timeout toxic behavior #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for the timeout toxic when timeout is set to zero simply reads from the input and then if it gets some data just has a comment: "// Drop the data on the ground". This change updates the docs do indicate the data is dropped, not delayed, until the texic is removed.
|
@bjornbyte Thanks for the contribution! Are you able to sign the CLA at https://cla.shopify.com/, and then once you have done so comment here with |
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for the timeout toxic when timeout is set to zero simply reads from the input and then if it gets some data just has a comment: "// Drop the data on the ground". This change updates the docs do indicate the data is dropped, not delayed, until the texic is removed.