Skip to content

Load the runtime patches before Spoom #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented May 23, 2025

Motivation

We need these to be loaded before, if not generating the RBI for Spoom won't contain generics.

Implementation

Tests

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar self-assigned this May 23, 2025
@Morriar Morriar requested a review from a team as a code owner May 23, 2025 21:37
@Morriar Morriar added the bugfix label May 23, 2025
@st0012
Copy link
Member

st0012 commented May 26, 2025

The build failure is unrelated to change (caused by rubygem's rdoc plugin) so I'm merging this and cut a release to unblock upgrade.

@st0012 st0012 merged commit 4853fbc into main May 26, 2025
17 of 19 checks passed
@st0012 st0012 deleted the at-fix-runtime-patchs-includes branch May 26, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants