Active Job 7+ perform_later takes an optional block #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
force-pushed
the
aj-perform-later-block
branch
3 times, most recently
from
d719932 to
3f73b28
Compare
vinistock
reviewed
Dec 14, 2023
bdewater
force-pushed
the
aj-perform-later-block
branch
from
3f73b28 to
8f4ffc3
Compare
vinistock
reviewed
Dec 14, 2023
bdewater
force-pushed
the
aj-perform-later-block
branch
from
8f4ffc3 to
b61ee1b
Compare
vinistock
approved these changes
Dec 15, 2023
bdewater
force-pushed
the
aj-perform-later-block
branch
from
b61ee1b to
ceabc81
Compare
|
@vinistock done! thanks for the feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Type rails/rails#41191
Implementation
Used a version check instead of the usual feature detection, since the source doesn't have an actual block parameter.
Tests
Tests updated