Add force option to RBS comment translation - #1000
Merged
Merged
Conversation
Morriar
force-pushed
the
at/rbs-comments-force
branch
from
August 6, 2026 17:33
54a0223 to
ea9cf09
Compare
Morriar
force-pushed
the
at/rbs-comments-force
branch
from
August 11, 2026 14:23
ea9cf09 to
e286ace
Compare
KaanOzkan
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
rbs_comments_to_sorbet_sigscurrently skips files without a valid Sorbet sigil, even when they contain RBS comments. Some callers need to translate those files explicitly (see https://github.com/Shopify/rubocop-sorbet/pull/397/changes#diff-6ba746ed3dcb37240ffd44cd598c2d3422c91bdadd54c8d2b8dcaf30c92006f0R188-R201).What changed?
Added an optional
force:argument torbs_comments_to_sorbet_sigs.When enabled, RBS comments are translated without requiring a valid
# typed:sigil. The source must still contain supported RBS syntax, and the default behavior remains unchanged.This option is limited to the Ruby API; CLI behavior is unchanged.