Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading all the plugins when creating the UI #4

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

pfryerdavis
Copy link

What changes were proposed in this pull request?

The SQL tab was not appearing for any job, including Spark SQL based jobs.

How was this patch tested?

Loading all plugins in the UI for every job, not just some of them.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@@ -141,7 +142,6 @@ private[history] class SimpleFsHistoryProvider(conf: SparkConf, clock: Clock)
// actually read, we may never refresh the app. FileStatus is guaranteed to be static
// after it's created, so we get a file size that is no bigger than what is actually read.
Utils.tryWithResource(EventLoggingListener.openEventLog(logPath, fs)) { in =>
logInfo("Trying to replay bus: $isCompleted, $eventsFilter")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this as a debug log and forgot to remove it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so couldn't we just log it to... debug? :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do that, fix up the grammar on it, but it looks more like it was used to just print some variables while Peter was working on it.

Copy link
Author

@pfryerdavis pfryerdavis Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content really isn't important on it. If I recall, I didn't even use the log line in testing.

@pfryerdavis pfryerdavis merged commit 57f77bd into branch-2.3-udf_nullability Jan 11, 2019
@pfryerdavis pfryerdavis deleted the shs-sql-2.3 branch January 11, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants