Loading all the plugins when creating the UI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,7 +142,6 @@ private[history] class SimpleFsHistoryProvider(conf: SparkConf, clock: Clock) | |||
| // actually read, we may never refresh the app. FileStatus is guaranteed to be static | |||
| // after it's created, so we get a file size that is no bigger than what is actually read. | |||
| Utils.tryWithResource(EventLoggingListener.openEventLog(logPath, fs)) { in => | |||
| logInfo("Trying to replay bus: $isCompleted, $eventsFilter") | |||
There was a problem hiding this comment.
I added this as a debug log and forgot to remove it.
There was a problem hiding this comment.
so couldn't we just log it to... debug? :)
There was a problem hiding this comment.
If we do that, fix up the grammar on it, but it looks more like it was used to just print some variables while Peter was working on it.
There was a problem hiding this comment.
The content really isn't important on it. If I recall, I didn't even use the log line in testing.
andrewdryder
approved these changes
Jan 11, 2019
MatthewRBruce
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The SQL tab was not appearing for any job, including Spark SQL based jobs.
How was this patch tested?
Loading all plugins in the UI for every job, not just some of them.
Please review http://spark.apache.org/contributing.html before opening a pull request.