This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Slate product section #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshold
force-pushed
the
slate-product-section
branch
3 times, most recently
from
1667fbc to
779a9f7
Compare
t-kelly
reviewed
Oct 25, 2016
| this.settings = { | ||
| eventNamespace: '.product' | ||
| }; | ||
| var sectionId = this.$container.attr('data-section-id'); | ||
|
|
||
| this.selectors = { |
There was a problem hiding this comment.
You could remove this from the constructor so that when you reference it you don't need this, i.e. selectors.addToCart
|
One small thing - otherwise 👍 |
cshold
force-pushed
the
slate-product-section
branch
from
779a9f7 to
eeb0760
Compare
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$('.selector-name', this.$container)section.idto their IDsenableHistoryStatesetting isn't required and defaults to false. Data attribute only needs to be set on the product templateEditor demo - https://carson-blocks.myshopify.com/admin/themes/132761987/editor
Home page with three featured products - http://carson-blocks.myshopify.com/
Product page with a few options - http://carson-blocks.myshopify.com/products/burton-dunmore-jacket-2016
@Shopify/themes-fed