This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Prevent the following of redirects for custom domains #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea. 👍 |
|
Getting a redirect loop on this.
Reproduce: I'm debugging further |
|
Love it though haha ❤️ |
|
Redirect issue fixed. @Shopify/themes-fed lookin' for some love on this PR |
|
There seems to be one issue where custom domain + password enabled still kicks you out of the proxy and browsersync |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merchants have redirection on for custom domains, browserstack was loading the page then following the redirect to the new URL:
This PR uses a query string param in Shopify (
?_fd=0) to prevent that forwarding. It also moves away from the generic query string proxying to using middleware, so the site can continue to be navigated and still keep that query string.@cshold @t-kelly
cc @m-ux