This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kelly
reviewed
Mar 20, 2017
docs/_layouts/default.html
Outdated
@@ -20,4 +20,5 @@ | |||
</div> | |||
</main> | |||
</body> | |||
<script src="{{ "/js/tracking.js" | prepend: site.baseurl }}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async
that bis-natch
t-kelly
approved these changes
Mar 20, 2017
bertiful
approved these changes
Mar 20, 2017
@@ -10,7 +10,9 @@ Slate allows you to sync local files with your live shop, deploy to multiple env | |||
|
|||
## Getting started | |||
|
|||
> [Node](https://nodejs.org/en/) 4+ is supported, but 6+ is recommended to fully benefit from Slate. If you want the template files without the build tools, [get the latest zip here](https://sdks.shopifycdn.com/slate/latest/slate-src.zip). | |||
<blockquote> | |||
<a href="https://nodejs.org/en/">Node</a> 4+ is supported, but 6+ is recommended to fully benefit from Slate. If you want the template files without the build tools, <a href="https://sdks.shopifycdn.com/slate/latest/slate-src.zip" data-ga-track="slateZip">get the latest zip here</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do you remember why we chose Node 4+ to be the minimum requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, maybe @macdonaldr93 could tell us.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interested in seeing how often people are downloading the zip from the docs site as opposed to GitHub.