Skip to content

[Feature] Add Loading component when react query is fetching #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Feature] Add Loading component when react query is fetching #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c3b95e
Add loading component
artyrcheek Nov 30, 2022
64076df
Update Loading to be a component rather than a wrapper
artyrcheek Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
QueryProvider,
PolarisProvider,
} from "./components";
import { ReactQueryLoading } from "./components/ReactQueryLoading";

export default function App() {
// Any .tsx or .jsx files in /pages will become a route
Expand All @@ -18,6 +19,7 @@ export default function App() {
<BrowserRouter>
<AppBridgeProvider>
<QueryProvider>
<ReactQueryLoading />
<NavigationMenu
navigationLinks={[
{
Expand Down
7 changes: 7 additions & 0 deletions components/ReactQueryLoading.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { useIsFetching } from "react-query";
import { Loading } from "@shopify/app-bridge-react";

export function ReactQueryLoading() {
const isFetching = useIsFetching();
return isFetching ? <Loading /> : null;
}