Skip to content

Accessing the taxes_included property on a ShopifyAPI::Shop object returns a Sorbet TypeError #1170

@raphaelfeitoza

Description

@raphaelfeitoza

Issue summary

Accessing the taxes_included property on a ShopifyAPI::Shop object returns a Sorbet TypeError due to a mismatch between the auto-generated type on the ShopifyAPI::Shop class and what gets returned in the body of the response

  • shopify_api version: 13.0.0
  • Ruby version: 3.2.2
  • Operating system: macOS
[12] pry(#<ShopRepository>)> shopify_shop.taxes_included
TypeError: Return value: Expected type T.nilable(String), got type FalseClass
Caller: (pry):10

Expected behavior

ShopifyAPI::Shop.all.first.taxes_included should return nillable boolean.

From the documentation: taxes_included: Whether applicable taxes are included in product prices. Valid values: true or null.

Actual behavior

ShopifyAPI::Shop.all.first.taxes_included returns a Sorbet type error: TypeError: Return value: Expected type T.nilable(String), got type FalseClass

Steps to reproduce the problem

  1. retrieve an Shop object through the auto-generated REST API resource class: shop = ShopifyAPI::Shop.all.first
  2. try to access the arguments property: shop.taxes_included

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions