This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 387
Function to authenticate flow requests #987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrichardpowell
force-pushed
the
authenticate-flow
branch
from
September 29, 2023 17:38
09b8469
to
49f8502
Compare
byrichardpowell
force-pushed
the
authenticate-flow
branch
from
October 24, 2023 15:30
49f8502
to
0286078
Compare
paulomarg
force-pushed
the
authenticate-flow
branch
from
January 30, 2024 19:32
0be0055
to
fc67b1b
Compare
paulomarg
changed the title
[WIP] - Function to authenticate flow requests
Function to authenticate flow requests
Jan 30, 2024
paulomarg
force-pushed
the
authenticate-flow
branch
from
January 30, 2024 20:50
c883867
to
c6e76cb
Compare
paulomarg
force-pushed
the
authenticate-flow
branch
from
January 30, 2024 20:51
c6e76cb
to
2de16fd
Compare
Ended up updating the process to ignore changeset files during the link checks. If any broken links are introduced, they'll show up in the release PRs :) |
4 tasks
lizkenyon
reviewed
Feb 5, 2024
lizkenyon
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We currently don't support Flow extension requests properly. While they use an HMAC signature similar to webhooks, they don't have all of the same headers, so their validation is slightly different.
WHAT is this pull request doing?
Adding a new way of supporting Flow extension requests under
shopify.flow.validate
.Type of change
Checklist
yarn changeset
to create a draft changelog entry (do NOT update theCHANGELOG.md
file manually)