Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Update multiple webhook handlers error #1290

Merged

Conversation

batuhannarci
Copy link
Contributor

@batuhannarci batuhannarci commented Mar 20, 2024

WHY are these changes introduced?

Fixes #1289

WHAT is this pull request doing?

This PR updates the error message.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@batuhannarci batuhannarci requested a review from a team as a code owner March 20, 2024 14:11
Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this!
One small wording change requested!

You can add an empty changeset to get the CI to pass.

You will also need to sign the CLI.

packages/shopify-api/lib/webhooks/registry.ts Outdated Show resolved Hide resolved
batuhannarci and others added 2 commits March 20, 2024 17:26
Co-authored-by: Liz Kenyon <lizkenyon07@gmail.com>
@batuhannarci batuhannarci requested a review from lizkenyon March 20, 2024 14:34
@lizkenyon
Copy link
Contributor

Hi there @batuhannarci

Looks like there are some failing tests. (Example) Once you get those passing we can merge this! Thanks again! ⭐

@batuhannarci
Copy link
Contributor Author

Hi @lizkenyon

I think all set this time 😄

@lizkenyon
Copy link
Contributor

Thank you again for your contribution!

@lizkenyon lizkenyon merged commit 84ddb5c into Shopify:main Mar 21, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Webhook Handlers Error
2 participants