Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Commit

Permalink
Clean up code using @shopify/prettier-config
Browse files Browse the repository at this point in the history
  • Loading branch information
Paulinakhew committed Jul 7, 2021
1 parent 35d8a7d commit 3382146
Show file tree
Hide file tree
Showing 63 changed files with 1,220 additions and 545 deletions.
6 changes: 1 addition & 5 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,23 @@
---
name: '🐛 Bug Report'
about: Something isn't working
labels: "Type: Bug 🐛"
labels: 'Type: Bug 🐛'
---

# Issue summary

Write a short description of the issue here ↓


## Expected behavior

What do you think should happen?


## Actual behavior

What actually happens?

Tip: include an error message (in a `<details></details>` tag) if your issue is related to an error


## Steps to reproduce the problem

1.
Expand All @@ -31,7 +28,6 @@ Tip: include an error message (in a `<details></details>` tag) if your issue is

The best way to get your bug fixed is to provide a [reduced test case](https://developer.mozilla.org/en-US/docs/Mozilla/QA/Reducing_testcases).


---

## Checklist
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/ENHANCEMENT.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: '📈 Enhancement'
about: Enhancement to our codebase that isn't a adding or changing a feature
labels: "Type: Enhancement 📈"
labels: 'Type: Enhancement 📈'
---

## Overview/summary
Expand All @@ -18,7 +18,6 @@ labels: "Type: Enhancement 📈"

- [ ] Add any relevant `Area: <area>` labels to this issue


---

## Checklist
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: '🙌 Feature Request'
about: Suggest a new feature, or changes to an existing one
labels: "Type: Feature Request :raised_hands:"
labels: 'Type: Feature Request :raised_hands:'
---

## Overview
Expand Down
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ Fixes #0000 <!-- link to issue if one exists -->
- [ ] Minor: New feature (non-breaking change which adds functionality)
- [ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)


## Checklist

- [ ] I have added a changelog entry, prefixed by the type of change noted above
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/markdown_link_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
config-file: '.github/workflows/markdown_link_checker_config.json'

- uses: actions/checkout@master
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
config-file: '.github/workflows/markdown_link_checker_config.json'
2 changes: 1 addition & 1 deletion .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
on: [ push, pull_request ]
on: [push, pull_request]
name: CI
jobs:
CI:
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,40 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- Don't include extra params when calculating local hmac [#196](https://github.com/Shopify/shopify-node-api/pull/196)

## [1.4.0] - 2021-05-21

### Added

- Add support for registering Google Pub/Sub webhooks [#181](https://github.com/Shopify/shopify-node-api/pull/181)
- Added `July21` to `ApiVersion` [#181](https://github.com/Shopify/shopify-node-api/pull/181)

## [1.3.0] - 2021-05-12

### Added

- Added Storefront API client under `Shopify.Clients.Storefront`
- Add `isActive()` method to `Session` class to check if session is active, replace `Session` with `SessionInterface` when used as a type [#153](https://github.com/Shopify/shopify-node-api/pull/153)

## [1.2.1] - 2021-03-26

### Added

- Added `April21` to `ApiVersion` [#149](https://github.com/Shopify/shopify-node-api/pull/149)

## [1.2.0] - 2021-03-16

### Added

- Allow plain objects to be returned from the `loadCallback` on `CustomSessionStorage` [#126](https://github.com/shopify/shopify-node-api/pull/126)
- Documentation and example code for `CustomSessionStorage` [#129](https://github.com/shopify/shopify-node-api/pull/129)

### Fixed

- Throw a different error for a missing cookie upon OAuth return [#131](https://github.com/shopify/shopify-node-api/pull/131)
- Improved documentation for GraphQL and Rest Clients. [#123](https://github.com/Shopify/shopify-node-api/pull/123)
- Made Docs directory more browseable in GitHub. [#136](https://github.com/Shopify/shopify-node-api/pull/136)
Expand Down
14 changes: 7 additions & 7 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ religion, or nationality.

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery
* Personal attacks
* Trolling or insulting/derogatory comments
* Public or private harassment
* Publishing other's private information, such as physical or electronic
addresses, without explicit permission
* Other unethical or unprofessional conduct
- The use of sexualized language or imagery
- Personal attacks
- Trolling or insulting/derogatory comments
- Public or private harassment
- Publishing other's private information, such as physical or electronic
addresses, without explicit permission
- Other unethical or unprofessional conduct

Project maintainers have the right and responsibility to remove, edit,
or reject comments, commits, code, wiki edits, issues, and other
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# `@shopify/shopify-api`

<!-- ![Build Status]() -->

[![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](LICENSE.md)
[![npm version](https://badge.fury.io/js/%40shopify%2Fshopify-api.svg)](https://badge.fury.io/js/%40shopify%2Fshopify-api)

Expand All @@ -18,6 +19,7 @@ This library can be used in any application that has a Node.js backend, since it
# Requirements

To follow these usage guides, you will need to:

- have a basic understanding of [Node.js](https://nodejs.org)
- have a Shopify Partner account and development store
- _OR_ have a test store where you can create a private app
Expand All @@ -27,6 +29,7 @@ To follow these usage guides, you will need to:
- have [yarn](https://yarnpkg.com) installed

<!-- Make sure this section is in sync with docs/README.md -->

# Getting started

You can follow our [getting started guide](docs/), which will provide instructions on how to create an app using plain Node.js code, or the [Express](https://expressjs.com/) framework. Both examples are written in Typescript.
Expand Down
6 changes: 5 additions & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,29 @@
1. Check the Semantic Versioning page for info on how to version the new release: http://semver.org

1. Ensure your local repo is up-to-date

```
git checkout main && git pull
```

1. Add an entry for the new release to `CHANGELOG.md`, and/or move the contents from the *Unreleased* to the new release
1. Add an entry for the new release to `CHANGELOG.md`, and/or move the contents from the _Unreleased_ to the new release

1. Increment the version in `src/version.ts`.

1. Stage the `CHANGELOG.md` and `src/version.ts` files

```
git add CHANGELOG.md src/version.ts
```

1. To update the version, create the appropriate tag, commit all staged changes and push to the remote repository

```
yarn version [ --patch | --minor | --major ]
```

Select the applicable option to the `yarn version` command to increment the appropriate part of the version number, i.e., for a version of `x.y.z`,

- `--patch` to increment the `z`
- `--minor` to increment the `y`
- `--major` to increment the `x`
Expand Down
Loading

0 comments on commit 3382146

Please sign in to comment.