-
Notifications
You must be signed in to change notification settings - Fork 85
Add automated workflow for pid #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92371ea to
b88adda
Compare
cf1475a to
1f04a67
Compare
nirmitparikh8
commented
Nov 4, 2025
experiments/results/protected_service/throughput-one_of_many_services_latency_degradation.png
Outdated
Show resolved
Hide resolved
nirmitparikh8
commented
Nov 4, 2025
experiments/results/protected_service/duration-one_of_many_services_latency_degradation.png
Outdated
Show resolved
Hide resolved
nirmitparikh8
commented
Nov 4, 2025
bbaae80 to
cca4c55
Compare
Contributor
AbdulRahmanAlHamali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a bunch of comments. But looks good overall!
A couple of thoughts:
- It seems CI did not run on your latest commit. I wonder if the last commit being made by the github action bot s blocking CI. Could you confirm?
- Also, we probably wanna do a fast followup after this that adds a CI that basically confirms that all the experiments have been rerun (basically by confirming that every PR is updating all existing results).
dfdc165 to
d65fa1d
Compare
Reset Update experiment graphs Delete existing image Done Update experiment graphs Update experiment graphs Refactor experiments folder and CI Update scope of commit Update experiment graphs Update experiment graphs Update Gemfile Update experiment graphs Move windup file into test folder Update experiment graphs CI should only commit main graphs Update experiment graphs New bot Fail fast Test Delete comment Update experiment graphs test Revert test Add the commit Test Test
Done Final
e42334d to
ac1de1e
Compare
AbdulRahmanAlHamali
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6619
Why This Is Important
This PR establishes automated validation for the adaptive PID controller circuit breaker implementation, ensuring performance regression detection and providing continuous benchmarking against classic circuit breakers across multiple failure scenarios.
What We're Accomplishing
Key Changes Made
1. CI Workflow Setup
.github/workflows/automated-experiment-result-checkeryml2. Experiment Infrastructure Refactor
experiments/experiments/directory and results intoexperiments/results/directoryrun_all_experiments.rbwith threaded execution (14 concurrent tests)3. Test Coverage
14 test scenarios comparing adaptive vs classic circuit breakers:
NOTE: We skip the lower_bound_adaptive test for the PID controller because it takes an hour. We will create a ticket to make it shorter or more optimized and then include it.
Future Steps
This new check will automatically help catch any regressions introduced by code changes.