Skip to content

Fix cold start issue #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2025
Merged

Fix cold start issue #809

merged 2 commits into from
Oct 21, 2025

Conversation

@nirmitparikh8
Copy link
Contributor

@nirmitparikh8 nirmitparikh8 commented Oct 21, 2025 •
edited
Loading

Fixes #6545

  • Add initial_history_duration and initial_error_rate param in the PID controller.
  • Added a prefill p90 estimator function that is called during the PID controllers initialization. This function just adds initial_error_rate as an observation n times. n = initial_history_duration/window_size

@nirmitparikh8 nirmitparikh8 changed the base branch from main to kris-gaudel/improved-estimator October 21, 2025 18:01
@nirmitparikh8 nirmitparikh8 marked this pull request as ready for review October 21, 2025 18:15
@nirmitparikh8 nirmitparikh8 force-pushed the nirmitparikh/cold-start-fix branch from 7f36017 to 6e3b97a Compare October 21, 2025 18:22
nirmitparikh8
nirmitparikh8 commented Oct 21, 2025
View reviewed changes
@nirmitparikh8 nirmitparikh8 changed the title Nirmitparikh/cold start fix Fix cold start issue Oct 21, 2025
@nirmitparikh8 nirmitparikh8 merged commit 982154a into kris-gaudel/improved-estimator Oct 21, 2025
1 check passed
@nirmitparikh8 nirmitparikh8 deleted the nirmitparikh/cold-start-fix branch October 21, 2025 18:38
AbdulRahmanAlHamali pushed a commit that referenced this pull request Oct 22, 2025
@nirmitparikh8 @AbdulRahmanAlHamali
Fix cold start issue (#809)
4a6f482 
* Prefilling added

* Change initial duration to 900 s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kris-gaudel kris-gaudel kris-gaudel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nirmitparikh8 @kris-gaudel