Fix Semian resource allocator pairing#1042
Merged
Merged
Conversation
rwstauner
force-pushed
the
rwstauner/less-crashy
branch
2 times, most recently
from
0262eac to
89cb5be
Compare
Ruby headers redefine strdup to ruby_strdup in C extensions, so res->name was allocated with Ruby's allocator even though it looked like libc strdup. Free it with xfree instead of free, and make the allocation explicit with ruby_strdup. Also release the malloc'd strkey field and add GC regression coverage for native resource cleanup.
rwstauner
force-pushed
the
rwstauner/less-crashy
branch
from
89cb5be to
8578234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby headers redefine strdup to ruby_strdup, so res->name was allocated with Ruby's allocator even though it looked like libc strdup. Free it with xfree instead of free, and make the allocation explicit with ruby_strdup.
Also release the malloc'd strkey field and add GC regression coverage for native resource cleanup.