Allow RBS comments without a leading space #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
config change
sambostock
reviewed
Feb 20, 2025
Comment on lines
+113
to
+115
| Layout/LeadingCommentSpace: | ||
| AllowRBSInlineAnnotation: true |
There was a problem hiding this comment.
CI is failing because this config is relatively recent.
To enable this config without bumping the minimum RuboCop version, we can use the same technique as we did to configure new cops:
Suggested change
| Layout/LeadingCommentSpace: | |
| AllowRBSInlineAnnotation: true | |
| <% if rubocop_version >= "1.67" %> | |
| Layout/LeadingCommentSpace: | |
| AllowRBSInlineAnnotation: true | |
| <% end %> |
There was a problem hiding this comment.
On the other hand, The Great Reset certainly warrants a major version bump, so we could take the opportunity to bump the minimum RuboCop version.
Thoughts @rafaelfranca?
Morriar
force-pushed
the
at--rbs-comment
branch
7 times, most recently
from
cc435b9 to
08c39dc
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at--rbs-comment
branch
from
923d120 to
c164bc4
Compare
This automated commit dumps the contents of the full RuboCop config. [dependabot skip]
sambostock
added a commit
that referenced
this pull request
Feb 21, 2025
rafaelfranca
added a commit
that referenced
this pull request
Mar 4, 2025
Allow RBS comments without a leading space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on Shopify/rubocop-sorbet#282 (comment).