Add rbs to composed bundle update commands#3938
Open
modille wants to merge 1 commit intoShopify:mainfrom
Open
Conversation
Without rbs in the update list, conservative mode can't resolve ruby-lsp 0.18+ for projects that don't have rbs locked, causing unexpected downgrades to 0.11.2. Fixes Shopify#3937
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3937
Implementation
I added
rbsto the gems array for thebundle updatecommand in both the launcher and non-launcher paths.Note
Should
prismbe in both of these places? And should--conservativebe consistent in both places?Automated Tests
I updated existing tests to expect rbs in the bundle update commands:
Manual Tests
I suspect this fixes the issue based on the manual workaround I found and documented in #3937
bundle updatecommand now includes rbs and that ruby-lsp is not downgraded