Skip to content

Run in terminal command above class name is not running all tests properly #2648

Open

Description

Description

Ruby LSP Information

VS Code Version

1.93.1

Ruby LSP Extension Version

0.8.2

Ruby LSP Server Version

0.18.4

Ruby LSP Addons

  • Ruby LSP Rails

Ruby Version

3.3.5

Ruby Version Manager

rbenv

Installed Extensions

Click to expand
  • vscode-erb-beautify (0.5.0)
  • vscode-eslint (3.0.10)
  • gitlens (15.5.1)
  • vscode-html-css (2.0.10)
  • EditorConfig (0.16.4)
  • copilot (1.234.0)
  • copilot-chat (0.20.3)
  • vscode-pull-request-github (0.96.0)
  • vscode-test-explorer (2.22.1)
  • vscode-rdbg (0.2.2)
  • rainbow-csv (3.12.0)
  • vscode-docker (1.29.3)
  • remote-containers (0.384.0)
  • test-adapter-converter (0.1.9)
  • vscode-yaml (1.15.0)
  • ruby-extensions-pack (0.1.12)
  • ruby-lsp (0.8.2)
  • sorbet-vscode-extension (0.3.37)
  • vscode-open-in-github (1.18.0)
  • typos-vscode (0.1.26)
  • vscode-icons (12.9.0)

Ruby LSP Settings

Click to expand
Workspace
{
  "rubyVersionManager": {
    "identifier": "rbenv"
  }
}
User
{
  "enableExperimentalFeatures": false,
  "enabledFeatures": {
    "codeActions": true,
    "diagnostics": true,
    "documentHighlights": true,
    "documentLink": true,
    "documentSymbols": true,
    "foldingRanges": true,
    "formatting": true,
    "hover": true,
    "inlayHint": true,
    "onTypeFormatting": true,
    "selectionRanges": true,
    "semanticHighlighting": true,
    "completion": true,
    "codeLens": true,
    "definition": true,
    "workspaceSymbol": true,
    "signatureHelp": true,
    "typeHierarchy": true
  },
  "featuresConfiguration": {},
  "addonSettings": {},
  "rubyVersionManager": {
    "identifier": "rbenv"
  },
  "customRubyCommand": "",
  "formatter": "auto",
  "linters": null,
  "bundleGemfile": "",
  "testTimeout": 30,
  "branch": "",
  "pullDiagnosticsOn": "both",
  "useBundlerCompose": false,
  "bypassTypechecker": false,
  "rubyExecutablePath": "",
  "indexing": {},
  "erbSupport": true
}

Reproduction steps

  1. Start the Ruby LSP using a certain editor
  2. Open a test file
  3. Run all tests in the file using the text 'Run in Terminal' that is above the class name
  4. This runs:
    {some path}/test_name.rb --name "/TestName(#|::)/"

Code snippet or error message

Running 3 tests in a single process (parallelization threshold is 50)
# Running tests with run options --name "/TestName(#|::)/" --seed 14178:
Finished tests in 0.000759s, 0.0000 tests/s, 0.0000 assertions/s.
0 tests, 0 assertions, 0 failures, 0 errors, 0 skips

I believe the name matching using --name argument doesn't actual run all the tests as required and as a result the summary at the end is incorrect. I have introduced an assert that should fail in my test however, no failures occur when I run all the tests using the 'Run in Terminal' button above the class name. When I run that individual test using 'Run in Terminal' then it does indeed fail as it should.

Please let me know if any other information is needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

bugSomething isn't workingvscodeThis pull request should be included in the VS Code extension's release notes

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions