Clear the model's association cache before resolving its association #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Aug 16, 2024
| @@ -152,6 +152,8 @@ def resolve_association_target(params) | |||
| } | |||
| end | |||
|
|
|||
| # Clear the cache so that we get the latest associations. | |||
| const.clear_reflections_cache | |||
There was a problem hiding this comment.
This approach would mean that we essentially never have reflections cached. Do we know how expensive that could be?
Would it be worth trying to only clear the cache based on file modifications, similar to how we handle reloading on schema changes?
andyw8
reviewed
Aug 16, 2024
gemfiles/Gemfile-rails-main
Outdated
| @@ -7,7 +7,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" } | |||
| gemspec path: ".." | |||
|
|
|||
| gem "puma" | |||
| gem "sqlite3", "< 2" | |||
| gem "sqlite3" | |||
There was a problem hiding this comment.
Do we still need the constraint in the main Gemfile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420
This PR also fixes the CI failure with Rails main Gemfile.