Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload the runner if structure.sql changes #341

Merged
merged 4 commits into from
May 2, 2024

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Apr 17, 2024

Closes #326

There already exists a test that modifications to structure.sql ends up reloading but without proper integration tests this behaviour isn't really testable.

To confirm this works:

  • Get a rails app with structure.sql
  • Make a change and save, look at the log output to validate it reloaded.
  • Make some changes to a *.rb file to confirm that this new listener doesn't overwrite the main one.

@Earlopain Earlopain marked this pull request as ready for review April 24, 2024 19:34
@Earlopain Earlopain requested a review from a team as a code owner April 24, 2024 19:34
@Earlopain Earlopain requested review from andyw8 and st0012 April 24, 2024 19:34
@andyw8
Copy link
Contributor

andyw8 commented Apr 26, 2024

Thank you! I've tested and it's working well.

@andyw8
Copy link
Contributor

andyw8 commented Apr 26, 2024

Let's also update workspace_did_change_watched_files to remove structure.sql? We can add a comment that it's only for Ruby files. Ignore, misunderstood.

@andyw8 andyw8 requested a review from vinistock April 26, 2024 18:15
@vinistock
Copy link
Member

Just needs a rebase, but LGTM.

@andyw8 andyw8 merged commit a49b02e into Shopify:main May 2, 2024
22 checks passed
@Earlopain Earlopain deleted the structure-sql-reload branch May 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying structure.sql doesn't trigger an update event
3 participants