Skip to content

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 29, 2024

This cop has been removed in #206, so we should remove it from the rubocop config as well. Otherwise, downstream users will see this error:

Error: The `Sorbet/OneAncestorPerLine` cop has been removed since `require_ancestor` now takes a block instead of arguments.
(obsolete configuration found in vendor/bundle/ruby/3.3.0/gems/rubocop-sorbet-0.8.2/config/rbi.yml, please update it)

This cop has been removed in #206, so we should remove it from the
rubocop config as well. Otherwise, downstream users will see this error:

```
Error: The `Sorbet/OneAncestorPerLine` cop has been removed since `require_ancestor` now takes a block instead of arguments.
(obsolete configuration found in vendor/bundle/ruby/3.3.0/gems/rubocop-sorbet-0.8.2/config/rbi.yml, please update it)
```
@st0012 st0012 added the bugfix Fix a bug label Apr 29, 2024
@st0012 st0012 requested a review from a team as a code owner April 29, 2024 11:55
@st0012 st0012 requested review from Morriar and egiurleo April 29, 2024 11:55
@st0012 st0012 merged commit d7fab34 into main Apr 29, 2024
@st0012 st0012 deleted the remove-outdated-cop-from-config branch April 29, 2024 12:19
@andyw8 andyw8 mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants