Introduce MultipleTEnumValues cop
#224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
force-pushed
the
emily/multi-t-enum-values
branch
from
012b6b0 to
3805c79
Compare
KaanOzkan
reviewed
Apr 15, 2024
Comment on lines
44
to
50
| def after_class(node) | ||
| @scopes.pop if t_enum?(node) | ||
| end |
There was a problem hiding this comment.
Which case does this cover?
There was a problem hiding this comment.
This covers the case where two T::Enum classes are nested together. It's not a pattern I've seen, but it is technically possible.
Example:
class Enum1 < T::Enum # @scopes = [Enum1]
class Enum2 < T::Enum # @scopes = [Enum1, Enum2]
...
end # @scopes = [Enum1]
end # @scopes = []
Morriar
reviewed
Apr 15, 2024
egiurleo
force-pushed
the
emily/multi-t-enum-values
branch
2 times, most recently
from
86a7724 to
f01193b
Compare
This cop ensures that all `T::Enum`s have at least two values to limit unnecessary uses of `T::Enum`. Co-authored-by: Stan Lo <stan.lo@shopify.com>
egiurleo
force-pushed
the
emily/multi-t-enum-values
branch
from
f01193b to
24c7e88
Compare
Morriar
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #219.
This cop ensures that all
T::Enums have at least two values to limit unnecessary uses ofT::Enum.